allow setting DB_ROOT_USER and DB_ROOT_PASS env variables for docker #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entrypoint. Also fix a few docker warnings in the Dockerfile
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow setting DB_ROOT_USER and DB_ROOT_PASS env variables for docker entrypoint. They default to the previous DB_USER and DB_PASS variables.
In our setup we are running homer with its own postgres account. It fails to start because it tries to connect to the "postgres" database with the "homer_user" account, which isn't permitted. This change makes sure it can do the necessary operations in the
9script of the docker-entrypoint.d directory.Also fix a few docker warnings in the Dockerfile while we're at it.