Renamed connector #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-115
to
-117
| ## Compatibility | ||
|
|
||
| Connector is compatible with R2DBC 1.0.0 spec. |
There was a problem hiding this comment.
Maybe we should leave this part here to indicate R2DBC version?
Collaborator
Author
There was a problem hiding this comment.
This compatibility is already mentioned above
Driver follow [R2DBC 1.0.0 specifications](https://r2dbc.io/spec/1.0.0.RELEASE/spec/html/)
| @@ -1,3 +1,3 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| // Copyright (c) 2020-2024 MariaDB Corporation Ab | |||
| // Copyright (c) 2025-2025 SingleStore, Inc. | |||
There was a problem hiding this comment.
we should leave MariaDB copyright in place and append ours on a new line
| @@ -1,223 +0,0 @@ | |||
| # Change Log | |||
There was a problem hiding this comment.
I'd rather leave this file in place, possible with a line like "Here is the first release".
README.md
Outdated
| SingleStore client, 100% Java, compatible with Java8+, apache 2.0 licensed. | ||
| Driver permits PAM authentication that comes with SingleStore. | ||
|
|
||
| Driver follow [R2DBC 1.0.0 specifications](https://r2dbc.io/spec/1.0.0.RELEASE/spec/html/) |
pmishchenko-ua
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.