Sac 28854 add new metadata changes #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new metadata configuration to the Listrak tap by introducing forced replication methods for all supported streams.
- Adds a
REPLICATION_METHODSdictionary mapping all streams toFULL_TABLEreplication - Creates a
CustomCatalogEntryclass that extends the standardCatalogEntrywith forced replication method support - Updates the discovery process to use the custom catalog entry with predefined replication methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tap_listrak/schemas.py | Defines replication methods dictionary mapping all streams to FULL_TABLE |
| tap_listrak/init.py | Implements CustomCatalogEntry class and updates discovery to use forced replication methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tap_listrak/__init__.py
Outdated
| class CustomCatalogEntry(CatalogEntry): | ||
|
|
||
| def __init__(self, *args, forced_replication_method=None, **kwargs): | ||
| self.forced_replication_method = kwargs.pop('forced_replication_method', forced_replication_method) |
There was a problem hiding this comment.
The parameter handling is redundant. The kwargs.pop() call with the same default value as the parameter creates unnecessary complexity. Consider simplifying to self.forced_replication_method = forced_replication_method.
Suggested change
| self.forced_replication_method = kwargs.pop('forced_replication_method', forced_replication_method) | |
| self.forced_replication_method = forced_replication_method |
RushiT0122
requested changes
Oct 16, 2025
tap_listrak/__init__.py
Outdated
| def to_dict(self): | ||
| result = super().to_dict() | ||
| if self.forced_replication_method is not None: | ||
| result['forced_replication_method'] = self.forced_replication_method |
There was a problem hiding this comment.
Suggested change
| result['forced_replication_method'] = self.forced_replication_method | |
| result['forced-replication-method'] = self.forced_replication_method |
tap_listrak/__init__.py
Outdated
| class CustomCatalogEntry(CatalogEntry): | ||
|
|
||
| def __init__(self, *args, forced_replication_method=None, **kwargs): | ||
| self.forced_replication_method = kwargs.pop('forced_replication_method', forced_replication_method) |
RushiT0122
requested changes
Oct 17, 2025
RushiT0122
reviewed
Oct 27, 2025
CHANGELOG.md
Outdated
| # Changelog | ||
|
|
||
| ## 1.2.0 | ||
| * forced replication method to metadata [#25](https://github.com/singer-io/tap-listrak/pull/25) |
There was a problem hiding this comment.
Suggested change
| * forced replication method to metadata [#25](https://github.com/singer-io/tap-listrak/pull/25) | |
| * Add forced replication method to metadata [#25](https://github.com/singer-io/tap-listrak/pull/25) |
RushiT0122
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add New Metadata to tap
SAC-28854
Risks
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code