TextTransformer: Allow yearly and weekly rules without a start date #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code would not work. It would throw
Fatal error: Uncaught Error: Call to a member function format() on null in /srv/www/Projekte/Web/mms-web/vendor/simshaun/recurr/src/Recurr/Transformer/TextTransformer.php:110:It will only work with and additional BYDAY, BYMONTHDAY,... or a start date in the Rule. However, I think it makes sense to be able to retrieve the text "yearly" for the above Rule. (As returned for the "daily", "monthly" or "hourly" rule without start date.)
The same applies to "weekly".
I added a simple check to fix the PHP error.