Skip to content

Conversation

@PCatinean
Copy link

Work in progress to filter different menus for both CMS's

@PCatinean
Copy link
Author

@simahawk I think this PR is ready. Let me know if anything needs changing or fixing.

@@ -0,0 +1,20 @@
<openerp>
Copy link

@leemannd leemannd Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<odoo> without <data>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small change but seems good to me 👍

@simahawk
Copy link
Owner

simahawk commented Oct 4, 2016

@PCatinean can you fix the small conflict in menu.xml. Should be just a matter of replacing <openerp /> with <odoo />, thanks.


</data>
</openerp>
<template id="submenu" name="Website CMS Submenu">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PCatinean any way to make this readable? :)

Maybe we can move this logic to a website helper method?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied and pasted the original navbar template from stock Odoo. I thought about using the original template but it's highly unlikely it will work.

Methods in the website helper might be a bit overkill, I set some variables at the start.

What do you think?

@simahawk
Copy link
Owner

totally fine :)

On Tue, Oct 11, 2016 at 9:18 PM, Paul Catinean [email protected]
wrote:

@PCatinean commented on this pull request.

In website_cms/templates/menu.xml
#1:

@@ -42,7 +41,28 @@

-
-
+

I copied and pasted the original navbar template from stock Odoo. I
thought about using the original template but it's highly unlikely it will
work.

Methods in the website helper might be a bit overkill, I set some
variables at the start.

What do you think?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVMDR89rw-nOTV73gLWhELriBypyfJXks5qy-DrgaJpZM4KMxe8
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants