Signed floats cbf #534
Open
Signed floats cbf #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added signed 32-bit floats (32-bit real IEEE) and signed 64-bit floats (64-bit real IEEE) as valid data types for arrays in cbf files
Added two missing commas to prior commit
|
I am not sure this is enough: yes float CBF are possible but we have been focusing on files produced by Pilatus detectors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, FabIO does not recognize signed floats as valid data type for .cbf files, only integers. However, floats are a legitimate possibility for the CBF standard, so I have added two lines to DATA_TYPES to accommodate this.