fix: extra fields in logs #8009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
waiting-on-author
michaelsproul
added
ready-for-merge
6 tasks
PoulavBhowmick03
added a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
Potentially fixes sigp#7995 changed `span_data` to a `HashMap` and added a new check to remove span fields whose base names are already present on the event. Co-Authored-By: PoulavBhowmick03 <[email protected]> Co-Authored-By: Michael Sproul <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
Potentially fixes sigp#7995 changed `span_data` to a `HashMap` and added a new check to remove span fields whose base names are already present on the event. Co-Authored-By: PoulavBhowmick03 <[email protected]> Co-Authored-By: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Potentially fixes #7995
Proposed Changes
changed
span_datato aHashMapand added a new check to remove span fields whose base names are already present on the event.