chore: clean dns code #9673
Merged
chore: clean dns code #9673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
approved these changes
Nov 8, 2024
frezbo
approved these changes
Nov 8, 2024
DmitriyMV
force-pushed
the
refactor-dns
branch
3 times, most recently
from
61bf5f2 to
875477a
Compare
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <[email protected]>
DmitriyMV
force-pushed
the
refactor-dns
branch
from
875477a to
4fe6dc8
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #9596 (without IPv6 stuff). This PR does this things:
DNSResolveCacheController. Most of the logic moved todnspackage types. Simplify and streamline logic.