feat: cluster create qemu presets #11906
Merged
+865
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orzelius
force-pushed
the
cluster-create-presets
branch
from
624687c to
2f942dd
Compare
Orzelius
force-pushed
the
cluster-create-presets
branch
4 times, most recently
from
d2adff8 to
fdf393a
Compare
|
Will there be an omni preset to join machines to an omni instance? |
@rothgar probably not in this pr, but yes, it's on the readmap! |
Orzelius
force-pushed
the
cluster-create-presets
branch
11 times, most recently
from
3754ed6 to
1ef2f02
Compare
Orzelius
changed the title
frezbo
reviewed
Oct 5, 2025
| qemu.StringVar(&cqOps.imageFactoryURL, "image-factory-url", "https://factory.talos.dev/", "image factory url") | ||
| qemu.StringVar(&presetOptions.schematicID, "schematic-id", "", "image factory schematic id (defaults to an empty schematic)") | ||
| qemu.StringVar(&presetOptions.imageFactoryURL, "image-factory-url", constants.ImageFactoryURL, "image factory url") | ||
| qemu.StringSliceVar(&presetOptions.presets, "presets", []string{preset.ISO{}.Name()}, "list of presets to apply") |
There was a problem hiding this comment.
if we only accept a single preset, why make this option a slice?
There was a problem hiding this comment.
ahh I see, we support merging, ignore comment then, thought I'm not sure if we should do iso,secureboot or have just iso and iso-secureboot
There was a problem hiding this comment.
Good point! I've simplified it to just iso-secureboot and it's much nicer this way
smira
reviewed
Oct 6, 2025
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/preset/disk_image_preset.go
Outdated
Show resolved
Hide resolved
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/preset/disk_image_preset.go
Outdated
Show resolved
Hide resolved
| --kubernetes-version string desired kubernetes version to run (default "1.34.1") | ||
| --memory-controlplanes string(mb,gb) the limit on memory usage for each control plane/VM (default 2.0GiB) | ||
| --memory-workers string(mb,gb) the limit on memory usage for each worker/VM (default 2.0GiB) | ||
| --presets strings list of presets to apply (default [iso]) |
There was a problem hiding this comment.
--presets=iso,omni=https://omni.com/siderolink?jointoken=foo
There was a problem hiding this comment.
I went with just adding a --omni-api-endpoint flag after some though as it seems like the most intuitive way to go about it. Also allows to add it to the existing dev command.
Orzelius
force-pushed
the
cluster-create-presets
branch
from
1ef2f02 to
eefa5e1
Compare
|
@rothgar I went ahead and also added a |
Orzelius
force-pushed
the
cluster-create-presets
branch
from
eefa5e1 to
d4e52d2
Compare
Orzelius
force-pushed
the
cluster-create-presets
branch
2 times, most recently
from
5e59515 to
1351784
Compare
dsseng
reviewed
Oct 16, 2025
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/internal/makers/helpers.go
Outdated
Show resolved
Hide resolved
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/preset/iso_preset.go
Outdated
Show resolved
Hide resolved
Orzelius
force-pushed
the
cluster-create-presets
branch
from
1351784 to
dd3fb1a
Compare
smira
reviewed
Oct 17, 2025
website/content/v1.12/talos-guides/install/local-platforms/qemu.md
Outdated
Show resolved
Hide resolved
smira
approved these changes
Oct 17, 2025
| - disk-image: Configure Talos to boot from a disk image from the image factory. | ||
| - maintenance: Skip applying machine configuration and leave the machines in maintenance mode. The machine configuration files are written to the working path. | ||
|
|
||
| Note: exactly one of 'iso', 'iso-secureboot', 'pxe' or 'disk-image' presets must be specified. |
There was a problem hiding this comment.
should omni-api-endpoint be documented as well?
There was a problem hiding this comment.
I've moved the docs and documented the flag in this pr siderolabs/docs#75
Orzelius
force-pushed
the
cluster-create-presets
branch
from
dd3fb1a to
94c3f81
Compare
* add 'iso', 'pxe', 'disk-image', 'maintenance' and 'secureboot' presets * swith the image-factory e2e test to use the create qemu command with presets * add a '--omni-api-endpoint' to simplify connecting machines to omni Signed-off-by: Orzelius <[email protected]>
Orzelius
force-pushed
the
cluster-create-presets
branch
from
94c3f81 to
eccb21d
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #11404
closes #11686
closes #11689