[SHRINKDESC-125] Add exportAsString-esque facility for Node SPI #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I understand it, this would be a new feature to the SPI only, not to any of the API or *-prototype modules. Also I think it'd be appropriate to accept some "Formatters" so that the String could have a custom formatting scheme (or one of our own canned ones). We have a very similar example in place in ShrinkWrap Archive.toString(Formatter). So while I completely appreciate this PR, perhaps we could limit the scope and tackle the requirements as above? WDYT? |
|
I am happy to make inline as it is with the shrinkwrap Archive toString() behaviour. Make sense to me. |
|
Cool. Recommend a new branch based off current upstream/master, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew
This feature is requested by Jesper. Can you review it?
I simply added the exportAsString functionality defined for descriptors into the Node class since the existing toString() is not usable IMO.
Thanks
Ralf