Fix bug arising from PyQt4 where QtGui.qApp is not initialized to None #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, in this first case we have what looks like a QApplication object, but it is not really there and will cause problems later. $ python -c 'from PyQt4 import QtGui; print QtGui.qApp' <PyQt4.QtGui.QApplication object at 0x7f2f884776b0> $ python -c 'from PySide import QtGui; print QtGui.qApp' None Instead we can use QtGui.QApplication.instance(), which always works and is documented in PySide to return the same as QtGui.qApp anyway.
|
Hi @manneohrstrom. Is there any chance this can be merged? To add more context, the code added by the two commits ac2ef1b and ca9059d makes use of The problem apparently exists in PyQt5 too (with a much better explanation): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in this first case we have what looks like a QApplication
object, but it is not really there and will cause problems later.
$ python -c 'from PyQt4 import QtGui; print QtGui.qApp'
<PyQt4.QtGui.QApplication object at 0x7f2f884776b0>
$ python -c 'from PySide import QtGui; print QtGui.qApp'
None
Instead we can use QtGui.QApplication.instance(), which always works and
is documented in PySide to return the same as QtGui.qApp anyway.