-
Notifications
You must be signed in to change notification settings - Fork 78
fix(api-types): update LineItem cover type from ProductMedia to Media across examples and packages #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… across examples and packages
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging #2127 will create unknown performance changesComparing Summary
Footnotes
|
patzick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
One question though - isn't the cover supposed to be a required property? What are the cases that it's missing, are you able to reproduce that case?
mkucmus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patzick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so should be
cover: components["schemas"]["Media"] | null
as the result


… across examples and packages
This pull request introduces an improvement to how product images are handled in the cart component, ensuring more consistent and simplified access to image data. The main change is in how the
coverproperty is referenced and used for cart items, both in the API schema and the Vue component.API Schema Update:
coverproperty to theLineItemschema, referencing theMediaschema to standardize how media is attached to cart items.Component Logic Simplification:
ProductItem.vueto directly usecartItem.coverinstead of accessing a nestedmediaproperty, aligning with the updated API schema and reducing complexity.