add: platzi.com #2501
Merged
add: platzi.com #2501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppfeister
requested changes
Sep 13, 2025
|
yes, either something changed or it wasn't robust enough, will fix!
|
- "username_claimed" is now set to "freddier" (the most popular user, just in case) - error code and request method are now explicit. - added trailing slash for consistency
|
I have enhanced the logic and tests are passing now: [*] Checking username freddier on:
[+] [1070ms] Platzi: https://platzi.com/p/freddier/
[*] Search completed with 1 resultsand [*] Checking username asdas123dasdasd123asdd1231asdsa on:
[*] Search completed with 0 results |
|
Checks out! Appreciate the contribution! error_code isn't really needed when it's a 404, but I think the GET is what fixed it. status_code checks default to HEAD rather than GET, which a few targets don't really like Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add: https://platzi.com