Skip to content

Conversation

MR-VL
Copy link
Contributor

@MR-VL MR-VL commented Jul 6, 2025

In regards to issue #2492. This PR adds support for Pychess.

image
image

fixes #2494
fixes #2492
fixes #2532

fixes #2495 seems like another merged PR already solves this will unlink

@MR-VL MR-VL changed the title Fix Issue #2492 Added support for Pychess Fix Issue #2492 and #2494 | Added support for Pychess | Remove TorrentGalaxy Jul 6, 2025
@MR-VL
Copy link
Contributor Author

MR-VL commented Jul 6, 2025

Also removed TorrentGalaxy in regards to #2494 as it appears the site has shut down and usernames are no longer searchable.

remove unmatched closing </a> tag, and fix indent
add quotes to <p align=center> LN:1 to make it valid HTML
fix type from programmaticaly to programmatically
@MR-VL MR-VL changed the title Fix Issue #2492 and #2494 | Added support for Pychess | Remove TorrentGalaxy Fix Issue #2492 and #2494 and #2495 | Added support for Pychess | Remove TorrentGalaxy | README.md syntax fixes Jul 6, 2025
@MR-VL
Copy link
Contributor Author

MR-VL commented Jul 6, 2025

Also fixed some errors in the README.md file in regards to #2495

LN1: <p align=center> is not valid HTML syntax 
* Changed to <p align="center">

LN19: </a> does not correspond to any opening tag
* Deleted unmatched closing <a> tag

LN119: programmaticaly is spelled incorrectly
* Fixed typo to programmatically

September 13 - Looks like another PR has solved this problem already. will remove it

Copy link

@manik6192 manik6192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MR-VL
Copy link
Contributor Author

MR-VL commented Sep 13, 2025

Looks like another PR solved #2495 and my existing commit in this PR was causing merge conflict. Changed Dropped those changes and it should be good. Not sure what is happening with the automatic testing though.

@MR-VL MR-VL changed the title Fix Issue #2492 and #2494 and #2495 | Added support for Pychess | Remove TorrentGalaxy | README.md syntax fixes Fix Issue #2492 and #2494 | Added support for Pychess | Remove TorrentGalaxy Sep 13, 2025
@MR-VL
Copy link
Contributor Author

MR-VL commented Sep 13, 2025

Also removed a trailing comma for the Cashapp entry that was breaking the TOX matrix

@ppfeister
Copy link
Member

All LGTM! Appreciate the contribution!
Merged into master.

@ppfeister ppfeister merged commit 5113dcf into sherlock-project:master Sep 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOX matrix broken in commit # 96460555 False positive for: TorrentGalaxy Requesting support for: pychess
3 participants