Skip to content

Conversation

@zokhasan
Copy link
Contributor

No description provided.

@pierreporte
Copy link

I don’t think it’s a good idea to add the command only if it’s already present.

@shaise what do you think?

@shaise
Copy link
Owner

shaise commented Jul 14, 2025

@pierreporte , please explain. what do you mean if it's already present?

@pierreporte
Copy link

@shaise The code checks if Sketcher_NewSketch or PartDesign_NewSketch are already present on the toolbars, and adds PartDesign_NewSketch only when they are not already there.

@shaise
Copy link
Owner

shaise commented Jul 14, 2025

@pierreporte , Yes, and what do you think should be the correct behavior?
In any case, I'm against setting it as a separate toolbar, it should be added as part of the main sheetmetal toolbar. Also the best thing is to automatically detect if it is a part sketch or partdesign sketch. if not, this should at least somehow be clear to the user what is he using. The icons are too similar

@pierreporte
Copy link

I would prefer that it’s added regardless of what the user already added to the toolbar, because it’s a UI/UX design choice, so it seems we agree.

As for the two similar commands, the best solution is to merge the two commands so that Sketcher_NewSketch can do everything: FreeCAD/FreeCAD#12106

@luzpaz
Copy link
Collaborator

luzpaz commented Aug 28, 2025

@shaise so to summarize you agree with the idea but not with the application of it ?

@shaise
Copy link
Owner

shaise commented Sep 4, 2025

@shaise so to summarize you agree with the idea but not with the application of it ?

yes

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 4, 2025

In any case, I'm against setting it as a separate toolbar, it should be added as part of the main sheetmetal toolbar. Also the best thing is to automatically detect if it is a part sketch or partdesign sketch. if not, this should at least somehow be clear to the user what is he using. The icons are too similar

@zokhasan what are your thoughts. Would you consider modifying it. Also considering the unknown future of FreeCAD/FreeCAD#12106

@zokhasan
Copy link
Contributor Author

Sorry @luzpaz , I just saw this message.
Honestly I'm not sure about this path, so I'll pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants