-
Notifications
You must be signed in to change notification settings - Fork 251
Expand system test framework #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
01395aa
to
1dee03d
Compare
@danlavu can you review this PR? |
Ack, will do it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of suggestions and preferences. Other than that, it looks good.
1dee03d
to
39db594
Compare
I do not have permissions to approve. The PR looks good. |
Thank you for the review! |
39db594
to
e725b96
Compare
Temporary workaround to create the newusers PAM service file. Fedora will soon provide this service file and we'll be able to remove the workaround. Signed-off-by: Iker Pedrosa <[email protected]>
Signed-off-by: Iker Pedrosa <[email protected]>
This is the transformation to Python of the test located in `tests/newusers/35_read_from_stdin/newusers.test`, which checks that `newusers` is able to create new users from stdin. Signed-off-by: Iker Pedrosa <[email protected]>
… input This is the transformation to Python of the test located in `tests/newusers/20_multiple_users/newusers.test`, which checks that `newusers` is able to create new users from file. Signed-off-by: Iker Pedrosa <[email protected]>
Temporary workaround to create the groupmems PAM service file. Fedora will soon provide this service file and we'll be able to remove the workaround. Signed-off-by: Iker Pedrosa <[email protected]>
…ems` Signed-off-by: Iker Pedrosa <[email protected]>
This is the transformation to Python of the test located in `tests/grouptools/groupmems/01_groupmems_root_add_user/groupmems.test`, which checks that `groupmems` is able to add a user to a group running as the root user. Signed-off-by: Iker Pedrosa <[email protected]>
Signed-off-by: Iker Pedrosa <[email protected]>
Signed-off-by: Iker Pedrosa <[email protected]>
Signed-off-by: Iker Pedrosa <[email protected]>
Change to a new group using `newgrp`. Signed-off-by: Iker Pedrosa <[email protected]>
e725b96
to
390aa4a
Compare
@alejandro-colomar this one is also ready for merging |
Expand the system test framework to provide python bindings for
newusers
,groupmems
andnewgrp
binaries. Also include at least one test case example for each of them. Additional changes has been made to the way we generate the test environment (a.k.a. containers) so that it contains everything needed to run these tests.