Skip to content

Conversation

ikerexxe
Copy link
Collaborator

Expand the system test framework to provide python bindings for newusers, groupmems and newgrp binaries. Also include at least one test case example for each of them. Additional changes has been made to the way we generate the test environment (a.k.a. containers) so that it contains everything needed to run these tests.

@ikerexxe ikerexxe marked this pull request as ready for review August 25, 2025 07:28
@ikerexxe
Copy link
Collaborator Author

@danlavu can you review this PR?

@danlavu
Copy link

danlavu commented Aug 27, 2025

Ack, will do it today.

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of suggestions and preferences. Other than that, it looks good.

@danlavu
Copy link

danlavu commented Aug 31, 2025

I do not have permissions to approve. The PR looks good.

@ikerexxe
Copy link
Collaborator Author

ikerexxe commented Sep 1, 2025

I do not have permissions to approve. The PR looks good.

Thank you for the review!

Temporary workaround to create the newusers PAM service file. Fedora
will soon provide this service file and we'll be able to remove the
workaround.

Signed-off-by: Iker Pedrosa <[email protected]>
This is the transformation to Python of the test located in
`tests/newusers/35_read_from_stdin/newusers.test`, which checks that
`newusers` is able to create new users from stdin.

Signed-off-by: Iker Pedrosa <[email protected]>
… input

This is the transformation to Python of the test located in
`tests/newusers/20_multiple_users/newusers.test`, which checks that
`newusers` is able to create new users from file.

Signed-off-by: Iker Pedrosa <[email protected]>
Temporary workaround to create the groupmems PAM service file. Fedora
will soon provide this service file and we'll be able to remove the
workaround.

Signed-off-by: Iker Pedrosa <[email protected]>
This is the transformation to Python of the test located in
`tests/grouptools/groupmems/01_groupmems_root_add_user/groupmems.test`,
which checks that `groupmems` is able to add a user to a group running
as the root user.

Signed-off-by: Iker Pedrosa <[email protected]>
Change to a new group using `newgrp`.

Signed-off-by: Iker Pedrosa <[email protected]>
@ikerexxe
Copy link
Collaborator Author

@alejandro-colomar this one is also ready for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants