Skip to content

fix(card): add "id" field to form and "form" field to button to improve from handling #8433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(card): add "id" field to form and "form" field to button to improve from handling #8433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/v4/app/(internal)/sink/components/card-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function CardDemo() {
</CardDescription>
</CardHeader>
<CardContent>
<form>
<form id="form-card-demo">
<div className="flex flex-col gap-6">
<div className="grid gap-2">
<Label htmlFor="email">Email</Label>
Expand All @@ -57,7 +57,7 @@ export function CardDemo() {
</form>
</CardContent>
<CardFooter className="flex-col gap-2">
<Button type="submit" className="w-full">
<Button type="submit" form="form-card-demo" className="w-full">
Login
</Button>
<Button variant="outline" className="w-full">
Expand Down
4 changes: 2 additions & 2 deletions apps/v4/registry/new-york-v4/examples/card-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function CardDemo() {
</CardAction>
</CardHeader>
<CardContent>
<form>
<form id="form-card-demo">
<div className="flex flex-col gap-6">
<div className="grid gap-2">
<Label htmlFor="email">Email</Label>
Expand All @@ -51,7 +51,7 @@ export default function CardDemo() {
</form>
</CardContent>
<CardFooter className="flex-col gap-2">
<Button type="submit" className="w-full">
<Button type="submit" form="form-card-demo" className="w-full">
Login
</Button>
<Button variant="outline" className="w-full">
Expand Down