fix(www): add TypeScript types to toc.ts #8411
Open
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes @ts-nocheck directive and adds proper type annotations to resolve 8 implicit any type errors. Uses existing UnistNode type from types/unist and adds null safety with optional chaining. No logic changes - only type improvements for better type safety.
|
@kpedrok is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes @ts-nocheck directive and adds proper TypeScript type annotations to apps/www/lib/toc.ts.
Fixes 8 implicit any type errors that were previously suppressed.
Changes
Testing
Build verification:
Application builds successfully. Table of contents functionality on documentation pages works correctly.
Note
Running
npx tsc lib/toc.tsin isolation shows a module resolution warning for types/unist. This is expected behavior - the import resolves correctly during actual builds using the baseUrl configuration in tsconfig.json, consistent with other files in the project (rehype-component.ts, rehype-npm-command.ts).Summary
Before: 8 TypeScript implicit any errors hidden by @ts-nocheck
After: Fully type-safe with zero errors