EC Levels #77
Open
EC Levels #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app/services/ClickHandler.coffee bundle.js
Conflicts: app/controllers/MathSwipeController.coffee app/services/ClickHandler.coffee app/views/Board.coffee bundle.js
|
We should have this branch as the base feature branch. We should branch off of this branch and add the features you listed below. I think we should have an animation that shows that you're leveling up. In addition, I'd like to have a slider on changing the level. A bug that I noticed was that in 4x4 boards, the goals would sometimes over lap. Say the answers were all two or three digits each. The numbers would then overlap into each other making the answers unreadable. Other than that, the leveling system looks great. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sf-interns/owners This is a basic leveling setup for the app. It automatically levels up. Please give feedback on style and on which variables you want me to change.
I'm looking into why merging is messed up
Changes that should be made that are not in the scope of this pr, but should be done in future ones
Select level from home pageSession Tracking and current-level storage[not feasible with current static site ]