-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update hardhat packages (major) #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
package.json
Outdated
| "@nomicfoundation/hardhat-foundry": "1.2.0", | ||
| "@nomicfoundation/hardhat-ignition-viem": "0.15.15", | ||
| "@nomicfoundation/hardhat-toolbox-viem": "4.1.1", | ||
| "@nomicfoundation/hardhat-ignition-viem": "3.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing `
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
Hardhat 3.0.11 requires `
💡 Suggested Fix
Add `
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L41
Potential issue: Hardhat 3.0.11 requires `
Did we get this right? 👍 / 👎 to inform future reviews.
| "@nomicfoundation/hardhat-toolbox-viem": "4.1.1", | ||
| "@nomicfoundation/hardhat-ignition-viem": "3.0.4", | ||
| "@nomicfoundation/hardhat-toolbox-viem": "5.0.1", | ||
| "@nomiclabs/hardhat-solhint": "4.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardhat 3 plugins are not explicitly registered in hardhat.config.ts's plugins array.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
Hardhat 3 requires plugins to be explicitly registered in the hardhat.config.ts file via a plugins array within the configuration object. The current configuration only imports plugins like @nomicfoundation/hardhat-foundry and @nomicfoundation/hardhat-toolbox-viem using side-effect imports, without adding them to the required plugins array. This will prevent the plugins from loading, leading to loss of their functionality, and causing runtime failures for tasks or features that depend on them, such as Hardhat Ignition or contract verification.
💡 Suggested Fix
Modify hardhat.config.ts to include a plugins array in the HardhatUserConfig object, explicitly listing all required plugins (e.g., plugins: [hardhatViem, hardhatFoundry, hardhatSolhint]).
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L43
Potential issue: Hardhat 3 requires plugins to be explicitly registered in the
`hardhat.config.ts` file via a `plugins` array within the configuration object. The
current configuration only imports plugins like `@nomicfoundation/hardhat-foundry` and
`@nomicfoundation/hardhat-toolbox-viem` using side-effect imports, without adding them
to the required `plugins` array. This will prevent the plugins from loading, leading to
loss of their functionality, and causing runtime failures for tasks or features that
depend on them, such as Hardhat Ignition or contract verification.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="package.json">
<violation number="1" location="package.json:46">
This PR introduces incompatible Hardhat plugins. The versions of `@nomicfoundation/hardhat-foundry` and `@nomiclabs/hardhat-solhint` are not compatible with Hardhat v3, which will break the project's testing and linting workflows.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
package.json
Outdated
| "@openzeppelin/contracts": "5.4.0", | ||
| "@openzeppelin/subgraphs": "0.1.8-5", | ||
| "hardhat": "2.26.5", | ||
| "hardhat": "3.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces incompatible Hardhat plugins. The versions of @nomicfoundation/hardhat-foundry and @nomiclabs/hardhat-solhint are not compatible with Hardhat v3, which will break the project's testing and linting workflows.
Prompt for AI agents
Address the following comment on package.json at line 46:
<comment>This PR introduces incompatible Hardhat plugins. The versions of `@nomicfoundation/hardhat-foundry` and `@nomiclabs/hardhat-solhint` are not compatible with Hardhat v3, which will break the project's testing and linting workflows.</comment>
<file context>
@@ -38,12 +38,12 @@
"@openzeppelin/contracts": "5.4.0",
"@openzeppelin/subgraphs": "0.1.8-5",
- "hardhat": "2.26.5",
+ "hardhat": "3.0.11",
"solhint": "6.0.1"
},
</file context>
9ea1470 to
57d7848
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
57d7848 to
ba8732c
Compare
This PR contains the following updates:
0.15.15->3.0.54.1.1->5.0.12.27.0->3.0.15Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
NomicFoundation/hardhat (@nomicfoundation/hardhat-ignition-viem)
v3.0.5Compare Source
Patch Changes
d1c1803: Make@nomicfoundation/hardhat-ignition's UI work well with other plugins, like Ledger's.v3.0.4Compare Source
Patch Changes
843c1ae: Fixed a bug preventing Ignition from using thehre.config.ignitionsettings when deploying via script (#7641)558ac5b: Update installation and config instructionsv3.0.3Compare Source
Patch Changes
bebf87c: Added support for Linea network verification, thanks @kyzooghost (#7357)v3.0.2Compare Source
Patch Changes
ddefbff: Added guard to stop multiple simultaneous calls toignition.deploy(...)at once (#6440)v3.0.1Compare Source
Patch Changes
86cecc7: Fix the type guard to includem.encodeFunctionCallin those that do not submit transactions, thanks @radik878 (#7264)v3.0.0Compare Source
Major Changes
29cc141: First release of Hardhat 3!NomicFoundation/hardhat (@nomicfoundation/hardhat-toolbox-viem)
v5.0.1Compare Source
Patch Changes
558ac5b: Update installation and config instructionsv5.0.0Compare Source
Major Changes
29cc141: First release of Hardhat 3!NomicFoundation/hardhat (hardhat)
v3.0.15Compare Source
Patch Changes
9fb054a: Fix the initialization of the Mocha and Ethers sample project when using pnpmv3.0.14Compare Source
Patch Changes
3d42a6f: Remove the compilation spinner when the compilation fails52e1eb4: Fix thetest soliditytask's compilation processce5c22a: Fail when a file isn't built neither as contract nor testv3.0.13Compare Source
Patch Changes
6e4ad6d: Fixed unexpected test failure when running in isolate/gas stats mode (#1146)6e4ad6d: Added latest dynamic base fee parameters to Base Mainnet chain config (#1141)v3.0.12Compare Source
Patch Changes
147f8a6: Improved the look and feel of compilation output (#7669)50ce3e0: Fix a bug that could lead to different builds having the same build id. Note that this version will change how every build id is computed.31f0b03: Don't compile solidity tests files when not needed (#7669)a77c06a: Added a new minimal sample projectv3.0.11Compare Source
Patch Changes
a4733f6: AdddefineConfiginhardhat/config52d9902: Fix package manager detectiond45234d: Fixed Etherscan verification failures by removing hardcoded v1 API URLs from chain descriptors (#7623). Also enhanced config resolution to support partial overrides in block explorer configurations for future extensibility.v3.0.10Compare Source
Patch Changes
fe28daf: Added support for showing gas statistics after running tests (#7472 and #7503)1ab6b75: Optimism ISTHMUS hardfork support added to Hardhat (#7517)5e64246: Improved JS/TS test tasks to not compile Solidity tests (#7626)217a1a8: Fix arbitrum sepolia chain id in chain descriptors (thanks @aelmanaa!)8a03bd0: Fixed gas calculation for EIP-7702 refunds (#7606)8a03bd0: Make all parameters ofeth_feeHistoryrpc call required (#7606)v3.0.9Compare Source
Patch Changes
0ee442d: All test runners now set NODE_ENV to "test" in case it is not set before the tests start (#7511)b27b924: Fix bug in flatten task where ordering was incorrect (#7586)v3.0.8Compare Source
Patch Changes
d2c9a7f: Don't swallow the original error when trying to improve installation error messages (#7569)ec50793: ValidateinitialBaseFeePerGasagainst hardfork only for L1 chain type (#6181)v3.0.7Compare Source
Patch Changes
138d673: Addednetwork.createServer(...)to spawn a Hardhat node programmatically (#6472)d414eda: Added support for conditional dependencies on plugins (#7424)138d673: Added support for compiling solidity tests separately from contracts (#6474)e17972f: Addedhre.versionswith Hardhat and EDR package versions.34add2d: Added configVariable support for test.solidity.forking configb13620a: Added compilation progress spinner to show build progress (#7460)4c65d3e: Automatically add compilation results to a runningnpx hardhat nodeon recompilation (#6040)138d673: Updated EDR to version0.12.0-next.7d821a0a: Fixed npm artifact cleanup on windows (#7459)138d673: Fixed creation of network connections to include config extensions from plugins (#7106)v3.0.6Compare Source
Patch Changes
609d05c: Add deprecation warning fortestFail_*test functions8c1cb1e: Fixed dependencies for Hardhat sorpcutils can be loaded (#7415)v3.0.5Compare Source
Patch Changes
bebf87c: Added support for Linea network verification, thanks @kyzooghost (#7357)0bfe6ac: Fixed coverage report when loading data from large test suites (#7385)be469d6: Display an error message when attempting to use a global hardhat installation in a local repo (#5362)49cc9ba: Load resolved global options into environment variables during tests (#7305)8d3b16c: Support for custom compilers (#7130)a475780: Added automatic proxy detection forhardhat-verifyand fixed case-insensitive proxy environment variables for network requests (#7407)3996886: FixedgetBuildInfoPathandgetBuildInfoOutputPathto correctly return undefined when build info files are missing 7052v3.0.4Compare Source
Patch Changes
af301a8: Update validation for solidity test config (#7205)v3.0.3Compare Source
Patch Changes
34a5bc9: Fixed an issue when making historical calls in a forked network (#7271)e0e658a: Upgraded EDR to 0.12.0-next.5. This brings a fix forexpectEmitcheatcode stack traces and performance improvements from upgrading to REVM 27 (#1063)v3.0.2Compare Source
Patch Changes
d45d544: Fixed passing global network options to node:test and mocha subprocesses (#7248)003e72c: Help message phrasing unified0120e67: Added warning when running with a non-LTS Node version (#7167)9261714: Update npm module regex to include versions in solidity imports (#7308)v3.0.1Compare Source
Patch Changes
a3bd239: Add Yarn support for Hardhat v3 (#7192)617254e: Move extraneous dependency to peer (#7231)6446a38: Add temporary fix for incorrect error message (#7168)6361ea4: Fixed an issue with compiling a Hardhat project after switching OS users (#7161)5c9ee7f: Warn the user if they are not using the latest version of Hardhat0fc1f3f: Remove full stops from help message descriptions (#7185)8acf48f: Improved exception filtering for Sentry telemetry (#7246)e7d2f80: Added missing Solidity test config optionallowInternalExpectRevert.v3.0.0Compare Source
Major Changes
29cc141: First release of Hardhat 3!Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.