Fix #359 - Add support to DSL 1.0.0 #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_#359
branch
11 times, most recently
from
1423aa5 to
f98ff62
Compare
ricardozanini
changed the title
fjtirado
force-pushed
the
Fix_#359
branch
2 times, most recently
from
446c834 to
84943b5
Compare
fjtirado
force-pushed
the
Fix_#359
branch
10 times, most recently
from
6c588f3 to
008f450
Compare
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado
force-pushed
the
Fix_#359
branch
6 times, most recently
from
907107f to
dbf11fe
Compare
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado
force-pushed
the
Fix_#359
branch
3 times, most recently
from
54446d4 to
386c5d9
Compare
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
custom-generator/src/main/java/io/serverlessworkflow/generator/AllAnyOneOfSchemaRule.java
Show resolved
Hide resolved
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
It is, but I do not like the TaskItem.getAdditionalProperties() (it can be seen in the unit test) and we can try to generate serialiazers rather than hardcoding them. Im not sure if that should be done with this PR or a follow up one |
|
I suggest having the most effective one for a snapshot in the main, then open follow-up issues. We can add a milestone to communicate to the community the roadmap/directions of this new version. |
ricardozanini
approved these changes
Jun 26, 2024
|
WhiteSource is failing duo to their internal error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
fix #359
Special notes for reviewers:
Full refactor of the SDK to read files from the new DSL
Additional information (if needed):