feat: support e2e sqs using localstack mock #1824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
acco
reviewed
Jun 18, 2025
| @@ -18,15 +18,18 @@ defmodule Sequin.Consumers.SqsSink do | |||
| field :access_key_id, :string | |||
| field :secret_access_key, Encrypted.Field | |||
| field :is_fifo, :boolean, default: false | |||
| field :endpoint, :string | |||
| field :proto, :string | |||
There was a problem hiding this comment.
We use scheme elsewhere to match URI
Comment on lines
+70
to
+77
| client = | ||
| if sink.endpoint do | ||
| client | ||
| |> Map.put(:endpoint, sink.endpoint) | ||
| |> Map.put(:proto, sink.proto) | ||
| else | ||
| client | ||
| end |
Comment on lines
+99
to
+105
| AWS_ENDPOINT: http://localstack:4566 | ||
| AWS_NO_VERIFY_SSL: "1" | ||
| AWS_DISABLE_SSL: "1" | ||
| AWS_SDK_LOAD_CONFIG: "0" | ||
| AWS_ACCESS_KEY_ID: "test" | ||
| AWS_SECRET_ACCESS_KEY: "test" | ||
| AWS_DEFAULT_REGION: "us-east-1" |
There was a problem hiding this comment.
Interesting, are all these env vars actually used?
| describe "sqs integration" do | ||
| @tag :sqs | ||
| test "changes are streamed to sqs", %{conn: conn, tid: tid, queue_url: queue_url, aws_client: client} do | ||
| IO.inspect(queue_url) |
Comment on lines
+170
to
+175
| e2e-test: ## Run the e2e test suite with specific tag: make e2e-test tag=kafka | ||
| @if [ -z "$(tag)" ]; then \ | ||
| echo "Usage: make e2e-test tag=<tag-name> (available tags: kafka, sqs)"; \ | ||
| exit 1; \ | ||
| fi | ||
| cd priv/tests_e2e && elixir tests.exs $(tag) |
There was a problem hiding this comment.
Cool - so this runs a specific, and the one above runs all?
acco
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.