-
Notifications
You must be signed in to change notification settings - Fork 9
docs: Add detailed explication of IAM policies #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These look great to me. I don't have write permissions on the repo, but looks good to merge. |
|
This looks awesome, @gavinelder! Can we use it in the public documentation? |
|
@justinegeffen I would love for us to merge this into public docs |
Absolutely no problem doing that! I'll open a PR shortly. :) |
bebosudo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! I left some comments to improve the meaning. Happy to give this a second pass
Co-authored-by: Alberto Chiusole <[email protected]>
bebosudo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are some more possible improvements
|
Some feedback from a prospect getting set up on Seqera Platform for the first time on this PR:
|
|
@bebosudo, @gavinelder: would be great if we could merge this PR. Let me know how I can help push it over the line. :) |
bebosudo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments that I'll commit in the next step
…mention from forge readme
…and adding more context
The IAM user shouldn't be the one sending emails out
|
This is great, thanks all! I did an editorial pass to tidy up formatting and some minor language changes. Other than that, it's good to go on my side! |
Co-authored-by: Ken Brewer <[email protected]>
kenibrewer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a second look, a lot of these changes are big steps in the right direction. So let's merge this and improve in follow-on PRs if needed.
The following updated the existing tower IAM policy by segmenting it into resource classes so end users can customize this to suit their own specific needs.
There are no additional permissions / added or removed only changes to the logical grouping along within additional explanations as to how an end user can craft these policies themselves.
Please note that further to this an end user can define a custom IAM policy for CE environments manually giving them a finer level of control under the CE environment advanced options.