-
Notifications
You must be signed in to change notification settings - Fork 0
"Demo Refresh" Updates #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: godot-4.5
Are you sure you want to change the base?
Conversation
add game instructions to readme for those new to godot return DSN to original clarify readme, remove leftover function
5f94dac
to
ce27044
Compare
|
||
|
||
func _play_victory_animation(): | ||
# Results in error since "victory" animation doesn't exist. | ||
var goal_name: String = self.name | ||
SentrySDK.add_breadcrumb("Reached: " + goal_name, "Milestone") | ||
animation_player.play(victory_animation) | ||
animation_player.play(dance_victory_animation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this is only updated because we want the suspect commit to show something as recent as possible)
@limbonaut thanks for the review. Clarification question- you said:
Just to be 100% clear on the expected behavior: Are you saying that on the
The way I'm reading your comment is that the README updates inaccurately reflect the demo's behavior (because the screenshot uses the word 'crash', but really it's a runtime error), and that I should update the README to reflect the true behavior of runtime error. Can you let me know if i understand you correctly?
Acknowledged, I'll add screenshots + document this use case 👍
This one too! @bruno-garcia , thanks for reviewing as well!
I'll update this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for excellent README, everything worked for me.
Left a few suggestions
README.md
Outdated
- **F key**: Toggle fullscreen mode | ||
- **R key**: Reset the scene | ||
|
||
**Objective:** Jump to the red flag on the right. When you reach it, the demo will intentionally cause an error to showcase Sentry's crash reporting capabilities! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Objective:** Jump to the red flag on the right. When you reach it, the demo will intentionally cause an error to showcase Sentry's crash reporting capabilities! | |
**Objective:** Jump to the red flag on the right. When you reach it, the demo will intentionally cause an error to showcase Sentry's crash reporting capabilities! | |
Godot Editor window should be automatically re-focused showing a Stack Trace tab with: | |
`Invalid call. Nonexistent function 'run_victory_animation (via call)' in base 'Area2D (goal.gd)'.` | |
<img width="1597" height="937" alt="Image" src="https://github.com/user-attachments/assets/e37fa799-236c-4812-a597-b9409111e1e3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godot Editor window should be automatically re-focused showing a Stack Trace tab with:
@maxkosty Hmm, actually this doesn't happen to me on touching the flag! I am still able to move the character around after hitting the flag even though the error is logged, and the focus remains on the gameplay window
README.md
Outdated
|
||
**Objective:** Jump to the red flag on the right. When you reach it, the demo will intentionally cause an error to showcase Sentry's crash reporting capabilities! | ||
|
||
**Note:** Currently hitting the flag doesn't fully crash the game, but should trigger an error to be captured in Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Note:** Currently hitting the flag doesn't fully crash the game, but should trigger an error to be captured in Sentry. | |
**Note:** Currently hitting the flag doesn't fully crash the game (you could resume execution by clicking ⏸️) , but should trigger an error to be captured in Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(you could resume execution by clicking ⏸️)
hit_flag.mp4
Interesting, again, for me hitting the flag doesn't pause the game execution at all, so there is no need to click pause to get the character moving again; it never stops moving 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(on demo_refresh_updates
branch)
Co-authored-by: Max Kosty Maleyev <[email protected]>
Co-authored-by: Max Kosty Maleyev <[email protected]>
…s/godot into demo_refresh_updates
Summary
Minor updates as part of SE team's 'demo refresh initiative' - Notion page
We had the good fortune of @limbonaut and team already implementing nearly all of the core features. Thank you!
Some minor updates:
README
setup details for SEs who are brand new to Godotuser.id
tag setScreenshots
Godot Log attached
Set User ID
Testing