Skip to content

Conversation

squrious
Copy link
Collaborator

@squrious squrious commented Jan 14, 2025

Previous update for 2.21 used a wrong service id (.ux.twig_component.twig.component_runtime). This service was hidden and has been removed in UX 2.22.

This PR adds another way to bypass the twig component runtime, with a custom runtime loader.

PHPUnit fails because of new Twig deprecations, this has to be fixed in a future PR.

@squrious squrious marked this pull request as ready for review January 14, 2025 07:51
@ttsuru
Copy link

ttsuru commented Feb 2, 2025

When I try this pull request, I get an error with the code below.

<twig:Foo>
  <twig:Bar />
</twig:Foo>
Storybook\Exception\RenderException: Story render failed: An exception has been thrown during the rendering of a template ("Storybook context already exists.") in "aaaaaaa.html.twig" at line 2.
   at vendor/sensiolabs/storybook-bundle/src/StoryRenderer.php:40
   at Storybook\StoryRenderer->render(object(Story))      (vendor/sensiolabs/storybook-bundle/src/Controller/StorybookController.php:43)
   at Storybook\Controller\StorybookController->__invoke(object(Request), 'title--default')      (vendor/symfony/http-kernel/HttpKernel.php:183)

@ttsuru
Copy link

ttsuru commented Feb 21, 2025

ref #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants