-
Notifications
You must be signed in to change notification settings - Fork 722
feat: add support for python3.12 and 3.13 #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tiwarishubham635 I don't have permission to assign a reviewer to the PR. |
@tiwarishubham635 any updates on this? |
@@ -6,13 +6,11 @@ venv: clean | |||
virtualenv --python=python venv | |||
|
|||
install: venv | |||
. venv/bin/activate; pip install -r test/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why do we need to change the makefile? I think we can skip this
This looks good to me, just we can skip the Makefile change I feel. Also, can you add support for python 3.13 as well, else I'll have to raise a separate PR. |
@@ -17,7 +17,7 @@ jobs: | |||
timeout-minutes: 20 | |||
strategy: | |||
matrix: | |||
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11' ] | |||
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add 3.13 here as well?
This pull request has been around for a year now. For additional required changes, maintainers have access to modify the contents of this pull request. 👇 Cheers. 🥂 |
Thanks for this @meysam81! I have made the changes. One last thing before merging this. Is there any specific reason why we are adding setuptools to our requirements.txt? |
Yes, this is the reason 👇 ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Python3.12
fixes #1086
Checklist