Skip to content

feat: add support for python3.12 and 3.13 #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

meysam81
Copy link
Contributor

@meysam81 meysam81 commented Aug 24, 2024

Python3.12

fixes #1086

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@meysam81
Copy link
Contributor Author

@tiwarishubham635 I don't have permission to assign a reviewer to the PR.
But here you are.
Please review.

@corbinday
Copy link

@tiwarishubham635 any updates on this?

@@ -6,13 +6,11 @@ venv: clean
virtualenv --python=python venv

install: venv
. venv/bin/activate; pip install -r test/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me why do we need to change the makefile? I think we can skip this

@tiwarishubham635
Copy link
Contributor

This looks good to me, just we can skip the Makefile change I feel. Also, can you add support for python 3.13 as well, else I'll have to raise a separate PR.

@@ -17,7 +17,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11' ]
python-version: [ '2.7', '3.5', '3.6', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 3.13 here as well?

@meysam81
Copy link
Contributor Author

@tiwarishubham635

This pull request has been around for a year now.

For additional required changes, maintainers have access to modify the contents of this pull request. 👇

gh-pr

Cheers. 🥂

@tiwarishubham635 tiwarishubham635 changed the title feat: add support for python3.12 feat: add support for python3.12 and 3.13 Apr 12, 2025
@tiwarishubham635
Copy link
Contributor

@tiwarishubham635

This pull request has been around for a year now.

For additional required changes, maintainers have access to modify the contents of this pull request. 👇

gh-pr

Cheers. 🥂

Thanks for this @meysam81! I have made the changes. One last thing before merging this. Is there any specific reason why we are adding setuptools to our requirements.txt?

@meysam81
Copy link
Contributor Author

Yes, this is the reason 👇

Screenshot 2025-04-12 at 16 27 16

Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiwarishubham635 tiwarishubham635 merged commit ee54d81 into sendgrid:main Apr 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.12
3 participants