Skip to content

Allow package dirs #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: ext-react-7.2.2
Choose a base branch
from
Open

Conversation

nmatei
Copy link
Contributor

@nmatei nmatei commented Sep 11, 2020

allowing packageDirs to be able to use our own folders for packages & more important to be able to use useWorkspaces: true in lerna.json

example packageDirs: ["${workspace.dir}../../../../node_modules/@Company"]
then use nodeModulePath 2 folders back.
@nmatei
Copy link
Contributor Author

nmatei commented Sep 14, 2020

I've seen that "@sencha/ext-webpack-plugin" took place for "@sencha/ext-react-webpack-plugin", but that is not in public repo anymore...
or entire plugin will be deprecated?

@jnsencha
Copy link
Contributor

@nmatei I've reviewed your work. Unfortunately we don't use this repository any longer, it will be removed. You are welcome to submit a PR for the webpack plugin updates to the ext-webpack-plugin package located here: https://github.com/sencha/ext-allshared/tree/ext-allshared-7.4.x/packages/ext-webpack-plugin. You can also submit a PR against this repo for the artifacts file: https://github.com/sencha/ext-allshared/blob/e89272add4019d73ba5955786a1438c1a11b3a39/packages/ext-webpack-plugin/src/artifacts.js#L196

Thanks!

@jnsencha
Copy link
Contributor

@wemersonjanuario could you review these changes as well please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants