Update test output for compatibility with upcoming pluralization and formatting changes in GAP #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
WIP
wilfwilson
force-pushed
the
update-pluralization
branch
from
456b0ac to
a2d6c26
Compare
wilfwilson
force-pushed
the
update-pluralization
branch
from
a2d6c26 to
311bf90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make Semigroups compatible with gap-system/gap#4343, which is not yet merged.
I'm intending to do this by adding a bunch of lines such as
#@if CompareVersionNumbers(ReplacedString(GAPInfo.Version, "dev", ""), "4.16")in the test files at the appropriate points, and giving the new output and keeping the old. It's tedious, but in the long run it will work. I've made an analogous PR to Digraphs (digraphs/Digraphs#865); smallsemi will need one too.
The problem will come when we need to decide whether to merge the GAP PR first, or release the Semigroups package first. But I'll bury my head in the sand about that for now.