Update to use libsemigroups v3
#1087
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package to use
libsemigroupsv3.Presently, this is a draft and there is a lot more work to be done. In a few critical places, I have added errors of the form
"<the thing you are trying to do> is not yet implemented". With this, running any of the test files should clearly highlight further changes that need to be made.Some notable things still to be done:
Congruenceobjects fromFroidurePinobjects.FroidurePinobjects fromToddCoxeterobjects.Congruence::ntcfunction.FroidurePinobjects.