feat: Upgrade URL pattern matching library to support wildcard prefixes #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/semgrep/semgrep-network-broker into matthewdean/wildcard-prefix-support
vivekkhimani
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library we use for URL pattern matching,
urlpath, matches wildcards only if they are the last path segment in a URL. This has prevented us from allowing code access to GitLab repos which belong to subgroups and also confused customers who expected a path like "/foo*" to match a URL with that suffixResolve this by uprading from
urlpathtogo-urlpattern, an implementation of the URL Pattern standard. We also add tests to verify the wildcard matching behavior and a benchmark test to ensure an individual match attempt does not exceed a specified runtime budget and thus degrade Broker's performance.As implemented the URL Pattern objects are being constructed at match time. We can likely improve speed and memory efficiency by moving this to Broker startup at some complexity cost.