C14N options #29
Open
C14N options #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Please check the test results: https://github.com/selective-php/xmldsig/actions/runs/14814040829/job/41639555159?pr=29 |
|
Please check for the latest build result. Note: Locally you can also run "composer stan" or "composer test:all" to see the results. |
|
Did you check it out? |
|
I will check today. |
odan
reviewed
Jul 17, 2025
| { | ||
| $element = $element ?? $document->documentElement; | ||
|
|
||
| if ($element === null) { | ||
| throw new XmlSignerException('Invalid XML document element'); | ||
| } | ||
|
|
||
| $canonicalData = $element->C14N(true, false); | ||
| $canonicalData = $element->C14N($this->exclusive, false); |
odan
reviewed
Jul 17, 2025
|
|
||
| public function __construct( | ||
| CryptoSignerInterface $cryptoSigner, | ||
| bool $preserveWhiteSpace = true, |
There was a problem hiding this comment.
I would prefer having immutable with* Methods for these new parameters.
e.g. withPreserveWhiteSpace() and withExclusive()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing this library for the upcoming official electronic invoicing system required by the Dominican Republic's IRS (DGII).
For that use case, some parameters need to be set (related to C14N and preserving whitespaces). This pull request adds the option to specifying those parameters.