Skip to content

Draft for public facing documentation for Amazon Conversions API #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025

Conversation

bansrav
Copy link
Contributor

@bansrav bansrav commented Jun 4, 2025

Proposed changes

Adding draft for public facing documentation for Amazon Conversions API. We implemented a new destination action for Amazon conversion API as part of this pull request and now adding documentation for it.

Merge timing

  • ASAP once approved

Related issues (optional)

@bansrav bansrav requested a review from a team as a code owner June 4, 2025 05:12
@bansrav bansrav requested a review from stayseesong June 4, 2025 05:12
9. Follow the steps in [Customizing mappings](/docs/connections/destinations/actions/#customize-mappings).
10. Toggle **Enable Destination** on, then click **Save Changes**.

{% include components/actions-fields.html settings="true"%}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this tag here which I believe pulls the data based on the id passed similar to how Pinterest does. Is that rite? I am not able to see this in preview as I think it would appear after merging the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's right!

stayseesong
stayseesong previously approved these changes Jun 9, 2025
@bansrav
Copy link
Contributor Author

bansrav commented Jun 10, 2025

Can we merge this PR now as it's already approved? Are we waiting for any dependent step here?

@stayseesong
Copy link
Contributor

stayseesong commented Jun 12, 2025

@bansrav I'm waiting for @joe-ayoub-segment to give the final OK to approve for merge

@joe-ayoub-segment
Copy link
Contributor

hi @stayseesong the doc looks great. nice job @bansrav ! I wish all our other docs were as comprehensive ;)

@bansrav
Copy link
Contributor Author

bansrav commented Jun 16, 2025

hi @stayseesong , can you please merge the PR now as Joe has also approved?

@joe-ayoub-segment
Copy link
Contributor

Hi @stayseesong this looks good to go out. It's in Private beta.
Destination ID 683ef14a3f9aac157e3a3446

@stayseesong stayseesong dismissed stale reviews from joe-ayoub-segment and themself via b3ba611 June 16, 2025 18:09
@stayseesong
Copy link
Contributor

@bansrav this will get deployed in our next docs release on Thursday 6/19

@stayseesong stayseesong added the new-integration Added a new source or destination label Jun 16, 2025
@stayseesong stayseesong merged commit d4b1da3 into segmentio:develop Jun 16, 2025
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants