Skip to content

[Smart Hashing] Cleanup #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Smart Hashing] Cleanup #2883

wants to merge 1 commit into from

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Apr 24, 2025 •
edited
Loading

Removed old smart hashing util from actions core.
Use new hashing util in liveramp.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review April 24, 2025 05:29
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner April 24, 2025 05:29
varadarajan-tw
varadarajan-tw reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pls confirm after a round of sanity testing in stage/local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varadarajan-tw varadarajan-tw varadarajan-tw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
actions:core mode:cloud not-partner-eng-review (cloud) team:segment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsh-joshi99 @varadarajan-tw @joe-ayoub-segment