-
Notifications
You must be signed in to change notification settings - Fork 266
[STRATCONN-5489] - Add batch_keys to Klaviyo actions #2880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2470c87
to
62b67cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
===========================================
+ Coverage 32.57% 77.84% +45.27%
===========================================
Files 14 1049 +1035
Lines 703 19470 +18767
Branches 119 3818 +3699
===========================================
+ Hits 229 15157 +14928
- Misses 474 2969 +2495
- Partials 0 1344 +1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something you think would be worth it to add a unit test for? One that fails if some future developer changes this for some reason
@nick-Ag - Good idea. Added a snapshot test for batch key configuration. |
This PR adds a new hidden
batch_keys
mapping to all Klaviyo actions. This mapping controls how events are batched together.This PR in itself won't have any effect as it depends on https://github.com/segmentio/integrations-go/pull/449. The integrations-go changes are behind a flagon and we'll be doing a controlled rollout.
Test Doc - here
Testing