Skip to content

[Smart Hashing] Cleanup #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Smart Hashing] Cleanup #2876

wants to merge 2 commits into from

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Apr 23, 2025

Cleanup for smart hashing util.
Remove destination slugs and feature flag.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 89.04110% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (95b7875) to head (e7d04ad).

Files with missing lines Patch % Lines
...tinations/google-enhanced-conversions/functions.ts 81.81% 2 Missing ⚠️
...ed-conversions/uploadConversionAdjustment/index.ts 81.81% 2 Missing ⚠️
...d-conversions/uploadConversionAdjustment2/index.ts 81.81% 2 Missing ⚠️
...kages/destination-actions/src/lib/hashing-utils.ts 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
+ Coverage   77.86%   78.04%   +0.18%     
==========================================
  Files        1049     1049              
  Lines       19450    19410      -40     
  Branches     3814     3762      -52     
==========================================
+ Hits        15145    15149       +4     
+ Misses       2965     2962       -3     
+ Partials     1340     1299      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh-joshi99 harsh-joshi99 changed the title cleanup for smart hashing [Smart Hashing] Cleanup Apr 24, 2025
@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review April 24, 2025 05:29
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner April 24, 2025 05:29
varadarajan-tw
varadarajan-tw previously approved these changes Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants