Skip to content

Radius: Add timestamp attribute #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomBassa2004
Copy link

@TomBassa2004 TomBassa2004 commented May 31, 2025

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)

Recently I was using Scapy to parse and create some radius packets.
I have noticed not all attributes are implemented in the radius module, more specifically it was lacking one very common attribute and so I decided to add it -> Event Timestamp. It is taken from RFC 2869.

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (6c658dd) to head (738c08e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4759      +/-   ##
==========================================
+ Coverage   79.52%   82.15%   +2.63%     
==========================================
  Files         344      362      +18     
  Lines       87082    87361     +279     
==========================================
+ Hits        69251    71775    +2524     
+ Misses      17831    15586    -2245     
Files with missing lines Coverage Δ
scapy/layers/radius.py 92.39% <100.00%> (+0.05%) ⬆️

... and 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2
Copy link
Member

gpotter2 commented Jun 2, 2025

Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks

@TomBassa2004 TomBassa2004 force-pushed the add-radius-extensions branch from 06e1daa to 738c08e Compare June 2, 2025 10:06
@TomBassa2004
Copy link
Author

Hi ! Thanks for the PR. Could you move it so that it's in incremental order compared to the others? Thanks

Done:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants