Skip to content

Add tag attribute for binding PhpWeb instance to window #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add tag attribute for binding PhpWeb instance to window #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions source/php-tags.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,20 @@ const runPhpScriptTag = async (element) => {
canvas: scope.canvas,
});

// Option 1:

// Allow binding php into window via attribute data-bind-php-window='true'
// if(element.getAttribute('data-bind-php-window') === 'true'){
// window.php = php;
// }

// Option 2:

// Improved by allowing specific window binding name to avoid naming collisions
if(element.getAttribute('data-php-bind-window-as')){
window[element.getAttribute('data-php-bind-window-as')] = php;
}

php.inputString(input);

const outListener = event => {
Expand Down