Skip to content
This repository was archived by the owner on Feb 28, 2022. It is now read-only.

patch for issues with already-merged classification branch #30

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cpeter256
Copy link
Contributor

Fixed outstanding issues in 4.2-ml

@codecov-io
Copy link

codecov-io commented May 3, 2016

Current coverage is 62.70%

Merging #30 into master will increase coverage by +1.25%

  1. 2 files (not in diff) in ...landingzone/handlers were modified. more
    • Misses -35
    • Hits -8
  2. 3 files (not in diff) in ...landingzone/decoders were modified. more
    • Misses -2
    • Hits -49
  3. 2 files (not in diff) in DB/landingzone were modified. more
    • Misses -14
    • Hits -12
@@             master        #30   diff @@
==========================================
  Files             7          7          
  Lines           498        378   -120   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            306        237    -69   
+ Misses          192        141    -51   
  Partials          0          0          

Powered by Codecov. Last updated by 278dbc8...b3965a0

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 66.825% when pulling bdb332a on baseclassifier_patch into 278dbc8 on master.

@iangudger
Copy link
Member

iangudger commented May 4, 2016

Looks good.

Here are a few more changes I would like:

  • Format the SQL queries in DB/classification/dataset_converter_unit_tests.py
  • Modify the integration tests so that they work in the Vangrant/server environment
  • Fix or delete commented out test
  • Removed duplicated and commented out import line in DB/classification/test_RandomForestModel.py

@coveralls
Copy link

coveralls commented May 4, 2016

Coverage Status

Coverage remained the same at 66.825% when pulling 24e9d9f on baseclassifier_patch into 278dbc8 on master.

@coveralls
Copy link

coveralls commented May 4, 2016

Coverage Status

Coverage remained the same at 66.825% when pulling b3965a0 on baseclassifier_patch into 278dbc8 on master.

@iangudger
Copy link
Member

Please address my previous comments.

Once PR35 goes in, please merge those changes into this PR and get the functional and integration tests checked in previously working on CircleCI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants