Skip to content

Conversation

@sdubov
Copy link
Owner

@sdubov sdubov commented Oct 5, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Switch to 2019.3 SDK to verify Rider tests works (Rider tests run on local environment is available in 193 SDK only)
  • Update travis and Amazon configuration to set the env variable

Motivation and Context

Enable tests.

Related Issue(s)

None.

Testing

Screenshots (if appropriate)

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • Local run of gradlew check succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sdubov sdubov force-pushed the sdubov-enable-tests branch 7 times, most recently from 8812bc4 to 0949c38 Compare October 9, 2019 21:42
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #6 into feature/rider-support will increase coverage by 0.98%.
The diff coverage is 84.61%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             feature/rider-support       #6      +/-   ##
===========================================================
+ Coverage                     46.2%   47.19%   +0.98%     
- Complexity                     770      797      +27     
===========================================================
  Files                          220      222       +2     
  Lines                         7508     7514       +6     
  Branches                      1108     1106       -2     
===========================================================
+ Hits                          3469     3546      +77     
+ Misses                        3585     3511      -74     
- Partials                       454      457       +3
Flag Coverage Δ Complexity Δ
#unittest 47.19% <84.61%> (+0.98%) 797 <4> (+27) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ns/services/lambda/dotnet/DotNetSamDebugSupport.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ftware/aws/toolkits/jetbrains/ui/RegionSelector.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...jetbrains/settings/LambdaSettingsChangeListener.kt 100% <100%> (ø) 0 <0> (?)
.../aws/toolkits/jetbrains/settings/LambdaSettings.kt 90% <100%> (+12.22%) 4 <1> (+1) ⬆️
...s/toolkits/jetbrains/icons/RiderAwsIconsPatcher.kt 71.42% <50%> (+71.42%) 4 <2> (+4) ⬆️
...its/jetbrains/settings/LambdaGutterMarkSettings.kt 85.71% <85.71%> (ø) 1 <1> (?)
...ware/aws/toolkits/jetbrains/ui/ResourceSelector.kt 79.01% <0%> (-1.24%) 24% <0%> (ø)
...aws/toolkits/jetbrains/utils/CompatibilityUtils.kt 34.61% <0%> (ø) 7% <0%> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2165686...021c5e0. Read the comment docs.

@sdubov sdubov force-pushed the sdubov-enable-tests branch 14 times, most recently from 0721b4a to 47dc8e0 Compare October 16, 2019 07:31
* Switch to 2019.3 SDK to verify Rider tests works (Rider tests run on local environment is available in 193 SDK only)
* Update travis and Amazon configuration to set the env variable to run on local environment and avoid downloads from Rider internal repositories
* Fix LambdaGutterMarkHighlightingTest tests to set up custom toolset on Windows to avoid failures when loading Empty project
@sdubov sdubov force-pushed the sdubov-enable-tests branch 2 times, most recently from 0de26d4 to ba39be2 Compare October 16, 2019 17:55
@sdubov sdubov force-pushed the sdubov-enable-tests branch from ba39be2 to be15028 Compare October 16, 2019 20:23
abrooksv and others added 3 commits October 17, 2019 12:47
* Add new protocol setting instance to use for AWS settings on Rider backend
* Update logic to notify about lambda gutter marks setting been chnaged
* Minor fixes (add validator for SAM project template to make sure we are notified about missing SAM CLI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants