-
Notifications
You must be signed in to change notification settings - Fork 11
add the ability to specify sensitive data in the schema #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| type ConfigBlobSensitiveData struct { | ||
| // Path defines the path to the sensitive data leaf | ||
| Path string `json:"path,omitempty" protobuf:"bytes,1,opt,name=config"` | ||
| // Selects a key of a secret in the pod's namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably search the target/config resource namespace, or use the SecretReference with a key selector so that the namespace can also be defined
| // can be excludes | ||
| Schema SchemaSpecSchema `json:"schema" yaml:"schema"` | ||
| // SensitivePaths defines the paths in the schema that have sensitive data | ||
| SensitivePaths []string `json:"sensitivePaths,omitempty" yaml:"schema,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be auto-filled by the config paths too? I would assume so, and extra ones can be defined here
|
manage the sensitive paths through a dedicated CR: list of:
Role of the ConfigServer:
Role of the DataServer:
Other? |
Looks like what we discussed in the call - only question is about the config-server creating a CR: Am I understanding correctly that we will have a new SecretConfig resource, which is reconciled by config-server and will create a config intent through replacing |
|
I am not sure we do a dedicated CR or extend the config CR with the paths. it allows to interleave this in a given config. If the data server does the merging/ masking I feel it does not matter and hence we have more flexibility to the user as they can have different teams also for different parts of the config. |
|
So I feel it is best to handle the sensitive config in a seperate CRD, but there can be multiple to allow different teams to author different pieces of the config. This also Is easier for deviation handling, etc etc.. Do we store this in the same way in the apiserver, meaning not in etcd ? Can we also assume these paths are always YANG leafs ? |
add sensitive data capabilities to hide this information in the configserver.