feat(cql_auth): add cluster name to data source #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guicrocetti thank you for your contribution! We will take a look at this PR next week, thank you for your patience. |
There was a problem hiding this comment.
Pull Request Overview
Adds the cluster name as a computed/read-only attribute to the CQL auth data source so users can retrieve authentication details and cluster name in one lookup.
- Adds name field to data source schema and populates it via an added GetCluster API call.
- Updates example Terraform configuration and documentation to expose and describe the new name attribute.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/provider/cqlauth/cql_auth_data_source.go | Adds API call to fetch cluster and sets new name attribute in schema state. |
| examples/data-sources/scylladbcloud_cql_auth/data-source.tf | Adds output exposing the new name attribute. |
| docs/data-sources/cql_auth.md | Documents the new name read-only attribute. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The `scylladbcloud_cql_auth` data source now exposes the `name` of the cluster as a read-only attribute. This allows users to get the cluster name along with the CQL authentication details in a single data source. Signed-off-by: Guilherme Crocetti <[email protected]>
guicrocetti
force-pushed
the
add-cluster-name-to-cql-auth
branch
from
0d355c6 to
9a83e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scylladbcloud_cql_authdata source now exposes thenameof the cluster as a read-only attribute.This allows users to get the cluster name along with the CQL authentication details in a single data source.