fix(manager): restart Scylla after schema restoration only for Scylla 2024.1 or lower #12017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally restarts Scylla nodes after schema restoration based on the Scylla version. It only restarts nodes for Scylla versions 2024.1 and lower, as newer versions no longer require this restart.
Key changes:
- Adds version comparison logic using ComparableScyllaVersion
- Replaces unconditional restart with version-conditional restart after schema restoration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mikliapko
changed the title
pehala
reviewed
Sep 21, 2025
pehala
previously approved these changes
Sep 21, 2025
Restart Scylla only after schema restoration for versions 2024.1 or lower. For the newest versions of Scylla it's not required. Docs: https://manager.docs.scylladb.com/stable/restore/restore-schema.html https://manager.docs.scylladb.com/stable/restore/old-restore-schema.html
mikliapko
force-pushed
the
manager-schema-restore-conditional-restart
branch
from
91900e3 to
cb89103
Compare
pehala
approved these changes
Sep 22, 2025
|
@Michal-Leszczynski @scylladb/qa-maintainers Could you please take a look? |
|
@mikliapko new branch |
Michal-Leszczynski
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restart Scylla only after schema restoration for versions 2024.1 or lower. For the newest versions of Scylla it's not required.
Docs:
https://manager.docs.scylladb.com/stable/restore/restore-schema.html
https://manager.docs.scylladb.com/stable/restore/old-restore-schema.html
Testing
PR pre-checks (self review)
backportlabels