Skip to content

Support for L3 Validium (Cloak) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 105 commits into from
Oct 29, 2025
Merged

Support for L3 Validium (Cloak) #164

merged 105 commits into from
Oct 29, 2025

Conversation

@lightsing
Copy link
Member

No description provided.

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-integration Updates to the integration crate crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Aug 18, 2025
@lightsing lightsing changed the base branch from master to feat/exchange-code-2 August 18, 2025 08:14
@github-actions github-actions bot removed crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Aug 18, 2025
@lispc lispc requested a review from roynalnaruto August 18, 2025 10:52
@noel2004
Copy link
Member

replace the latest incorrect commits by force-pushing

noel2004 and others added 2 commits October 9, 2025 14:13
@noel2004 @lispc @roynalnaruto
[Fix] Issues for validium mode (#194)
f37ff50 
* fix issues in e2e test with coordinator

* add debug fields

* update commits

* Soundness issues in Validium (#196)

* fix: soundness issues in validium mode

* chore: rename method validium pi_hash

* chore: rename another pi_hash validium

* update commit

---------

Co-authored-by: Zhuo Zhang <[email protected]>
Co-authored-by: Rohit Narurkar <[email protected]>
@lispc
Merge remote-tracking branch 'origin/master' into feat/validium
16607db
@github-actions github-actions bot added the ci CI related updates label Oct 9, 2025
noel2004
noel2004 reviewed Oct 9, 2025
View reviewed changes
lispc
lispc reviewed Oct 28, 2025
View reviewed changes
lispc
lispc reviewed Oct 28, 2025
View reviewed changes
lispc
lispc reviewed Oct 28, 2025
View reviewed changes
lispc
lispc reviewed Oct 28, 2025
View reviewed changes
lispc
lispc approved these changes Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments. generally good.

@lispc lispc marked this pull request as ready for review October 28, 2025 03:25
@roynalnaruto roynalnaruto changed the title [DO NOT MERGE] L3 Validium Support for L3 Validium (Cloak) Oct 28, 2025
@roynalnaruto roynalnaruto mentioned this pull request Oct 28, 2025
Open
@roynalnaruto roynalnaruto requested a review from noel2004 October 28, 2025 16:09
noel2004
noel2004 approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e test passed now.

However I noticed that there is still no covering to the decryption process (all the l1 txs provided in e2e test is in fact unencrypted). We may update the test data later in another task.

@lispc lispc merged commit c48a4bc into master Oct 29, 2025
5 checks passed
@noel2004 noel2004 deleted the feat/validium branch October 29, 2025 01:32
@noel2004 noel2004 restored the feat/validium branch October 29, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@Thegaram Thegaram Thegaram left review comments

@lispc lispc lispc approved these changes

@noel2004 noel2004 noel2004 approved these changes

Assignees

No one assigned

Labels

ci CI related updates crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lightsing @lispc @noel2004 @roynalnaruto @Thegaram @Velaciela