feat(e2e tests): invalid block penalizes peer #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
reviewed
Aug 3, 2025
Comment on lines
+3
to
4
| #[derive(Debug)] | ||
| /// A type that represents the result of the engine driver future. |
There was a problem hiding this comment.
nit: we do comments then derive
Comment on lines
+206
to
+211
| let node0_rmn_handle = nodes[0].inner.add_ons_handle.rollup_manager_handle.clone(); | ||
| let node0_network_handle = node0_rmn_handle.get_network_handle().await.unwrap(); | ||
| let node0_id = node0_network_handle.inner().peer_id(); | ||
|
|
||
| let node1_rnm_handle = nodes[1].inner.add_ons_handle.rollup_manager_handle.clone(); | ||
| let node1_network_handle = node1_rnm_handle.get_network_handle().await.unwrap(); |
There was a problem hiding this comment.
I might be mistaking but isn't it possible to use nodes[i].inner.network?
There was a problem hiding this comment.
checked and we could just use nodes[i].inner.network, just need to update the announce_block method to:
let block = NewBlock {
block: ScrollBlock {
header: Header {
extra_data: Signature::new(U256::ONE, U256::ONE, false).as_bytes().into(),
..Default::default()
},
..Default::default()
},
..Default::default()
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following item of #141: