feat: graceful shutdown #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
reviewed
Jun 6, 2025
| l1_message.insert(self.get_connection()).await?; | ||
| models::l1_message::Entity::insert(l1_message) | ||
| .on_conflict( | ||
| OnConflict::column(models::l1_message::Column::QueueIndex).do_nothing().to_owned(), |
There was a problem hiding this comment.
could we have an edge case where we index an L1 message, shutdown, the L1 reorgs, and we don't update it because of the do_nothing directive?
| @@ -511,3 +532,18 @@ fn delayed_interval(interval: u64) -> Interval { | |||
| interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Delay); | |||
| interval | |||
| } | |||
|
|
|||
| /// Computes the starting block for the watcher from the database. | |||
| pub async fn compute_watcher_start_block_from_database( | |||
| .await? | ||
| .expect("Batch info must be present due to database query arguments"); | ||
| let block = self.get_highest_block_for_batch(batch.hash).await?; | ||
| tracing::info!(target:"test", "{:?}", block); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a graceful shutdown for the rollup node to ensure that critical in-flight tasks are driven to completion before shutdown.
Test strategy
The test implemented for this feature is to start up a rollup node externally to the EN, such that we can manually poll it. This is required such that we can simulate a crash/shutdown midway through the processing of a batch. We simulate a crash midway through processing and then ensure that the node can start up and reprocess the latest batch that we crashed at. We assert that the EN safe block progresses to the expected chain tip upon restart.
Note: There may be an edge case in which the finalized head is greater than the safe head on restart, as we revert to the safe head. As such, when we issue the forkchoice rule, we ensure that we only issue an update if the safe block hash is greater than the finalized block hash.
Implementation
The following modifications have been made to support this feature:
ConsolidationOutcometype to clean up the consolidation interfacerun_until_graceful_shutdownfunction on the RNM and integrate with the rethTaskExecutorScrollRollupConfig