fix(l1 follower, rollup verifier): blockhash mismatch #1192
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Semgrep found 1 Risk: Affected versions of github.com/btcsuite/btcd are vulnerable to Always-Incorrect Control Flow Implementation. The btcd Bitcoin client did not correctly re-implement Bitcoin Core's "FindAndDelete()" functionality. This logic is consensus-critical: the difference in behavior with the other Bitcoin clients can lead to btcd clients accepting an invalid Bitcoin block (or rejecting a valid one). Fix: Upgrade this library to at least version 0.24.2-beta.rc1 at go-ethereum/rollup/missing_header_fields/export-headers-toolkit/go.mod:14. Reference(s): GHSA-27vh-h6mc-q6g8, CVE-2024-38365 |
…port reset of syncing pipeline
| } | ||
|
|
||
| // rename the temporary file to the final file path | ||
| if err = os.Rename(tmpFilePath, m.filePath); err != nil { |
There was a problem hiding this comment.
Would there be a state where the file in m.filePath is created, but the err is still not nil in this line? If so, the file in m.filePath might be corrupted.
Or when ok is false, remove files in tmpFilePath and m.filePath in the meantime.
There was a problem hiding this comment.
I'm not sure exactly what you mean.
if _, err = io.Copy(tmpFile, io.TeeReader(resp.Body, writeCounter)); err != nil {
Is blocking and therefore everything thereafter is sequential as well.
There was a problem hiding this comment.
I previously thought renaming here might create the target file and fail (might be impossible). So the code in defer could be:
defer func() {
if !ok {
_ = os.Remove(tmpFilePath)
_ = os.Remove(m.filePath)
}
}()
But it (Rename) seems to be atomic, I'm fine with the current implementation.
…ng header fields file
| @@ -1880,15 +1880,17 @@ func (bc *BlockChain) BuildAndWriteBlock(parentBlock *types.Block, header *types | |||
|
|
|||
| header.ParentHash = parentBlock.Hash() | |||
|
|
|||
| // sanitize base fee | |||
| if header.BaseFee != nil && header.BaseFee.Cmp(common.Big0) == 0 { | |||
There was a problem hiding this comment.
What's the reason to reset the header's BaseFee?
| return nil, fmt.Errorf("cannot create missing header fields manager: %w", err) | ||
| } | ||
|
|
||
| eth.syncingPipeline, err = da_syncer.NewSyncingPipeline(context.Background(), eth.blockchain, chainConfig, eth.chainDb, l1Client, stack.Config().L1DeploymentBlock, config.DA, missingHeaderFieldsManager) |
There was a problem hiding this comment.
Why not init missingHeaderFieldsManager inside the SyncingPipeline?
| @@ -2,17 +2,19 @@ module github.com/scroll-tech/go-ethereum/export-headers-toolkit | |||
|
|
|||
| go 1.22 | |||
|
|
|||
| replace github.com/scroll-tech/go-ethereum => ../../.. | |||
| downloadURL, err := url.Parse(stack.Config().DAMissingHeaderFieldsBaseURL) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("invalid DAMissingHeaderFieldsBaseURL: %w", err) | ||
| } | ||
| downloadURL.Path = path.Join(downloadURL.Path, chainConfig.ChainID.String()+".bin") |
There was a problem hiding this comment.
How about:
downloadUrl := stack.Config().DAMissingHeaderFieldsBaseURL + "/" + chainConfig.ChainID.String()+".bin"
|
|
||
| func (m *Manager) GetMissingHeaderFields(headerNum uint64) (difficulty uint64, stateRoot common.Hash, coinbase common.Address, nonce types.BlockNonce, extraData []byte, err error) { | ||
| // lazy initialization: if the reader is not initialized this is the first time we read from the file | ||
| if m.reader == nil { |
|
another question: who upload the |
1. Purpose or design rationale of this PR
This PR fixes the problem of mismatching block hashes due to the missing header fields
difficultyandextraDatain DA. It should be reviewed in conjunction with #903, which provides a way to prepare this missing data and describes the format in more detail.Specifically, this PR implements a missing header fields manager that:
Tested on Sepolia:
After a restart the header file is not downloaded again. The L1 syncing process can just continue. As can be seen the generated block hash matches.
Tested on mainnet:
After a restart the header file is not downloaded again. The L1 syncing process can just continue. As can be seen the generated block hash matches.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?