Skip to content

Changed toString() to help() as to not disrupt reserved keywords #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed toString() to help() as to not disrupt reserved keywords #2

wants to merge 2 commits into from

Conversation

@resir014
Copy link
Member

@resir014 resir014 commented Aug 23, 2017

Also added it to the typings and documented on the readme.

f4hy
f4hy reviewed Oct 18, 2020
View reviewed changes
Profiler/typings.d.ts
start(): void;
status(): void;
stop(): void;
help(): void;
Copy link

@f4hy f4hy Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be help(): string; ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@f4hy f4hy f4hy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@resir014 @f4hy