Skip to content

test(interfaces): Test completion of veth peers #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test(interfaces): Test completion of veth peers #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f294b
test(interfaces): Test for missing ip or ifconfig
yedayak Jun 16, 2025
d0b6449
test(interfaces): Test completion of veth peers
yedayak Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion test/fixtures/shared/bin/ifconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

# Dummy "ifconfig -a" emulator
# Dummy "ifconfig -a" emulator, from net-tools 1.60, ifconfig 1.42 (2001-04-13)

cat <<EOF
eth0 Link encap:Ethernet HWaddr 33:33:33:33:33:33
Expand All @@ -21,4 +21,21 @@ lo Link encap:Local Loopback
TX packets:129059 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:0
RX bytes:7456154 (7.1 MiB) TX bytes:7456154 (7.1 MiB)

peer1 Link encap:Ethernet HWaddr 33:33:33:33:33:33
inet6 addr: fe80::000:0000:0000:0000/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:15 errors:0 dropped:0 overruns:0 frame:0
TX packets:15 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:1146 (1.1 Kb) TX bytes:1146 (1.1 Kb)

peer2 Link encap:Ethernet HWaddr 33:33:33:33:33:33
inet6 addr: fe80::000:0000:0000:0000/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:15 errors:0 dropped:0 overruns:0 frame:0
TX packets:15 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:1146 (1.1 Kb) TX bytes:1146 (1.1 Kb)

EOF
12 changes: 12 additions & 0 deletions test/fixtures/shared/bin/ip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ for arg in "$@"; do
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff link-netnsid 0
5: peer2@peer1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff
6: peer1@peer2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff
EOF
exit 0
;;
Expand All @@ -27,6 +31,14 @@ EOF
valid_lft forever preferred_lft forever
inet6 fe80::000:0000:0000:0000/64 scope link
valid_lft forever preferred_lft forever
5: peer2@peer1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff
inet6 fe80::000:0000:0000:0000/64 scope link
valid_lft forever preferred_lft forever
6: peer1@peer2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 33:33:33:33:33:33 brd ff:ff:ff:ff:ff:ff
inet6 fe80::000:0000:0000:0000/64 scope link
valid_lft forever preferred_lft forever
EOF
exit 0
;;
Expand Down
27 changes: 25 additions & 2 deletions test/t/unit/test_unit_compgen_available_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

from conftest import assert_bash_exec
from conftest import assert_bash_exec, bash_env_saved


@pytest.mark.bashcomp(cmd=None)
Expand All @@ -16,10 +16,33 @@ def functions(self, bash):
'_comp__test_compgen() { local -a arr=(00); _comp_compgen -v arr "$@"; _comp__test_dump; }',
)

def test_1_trailing_colons(self, bash, functions):
# We fallback to ifconfig if ip fails, so we want to check also the scenario without ip.
@pytest.fixture(scope="function", params=["ip", "ifconfig"])
def remove_one_tool(self, request, bash):
assert_bash_exec(bash, f"{request.param}() {{ false; }}")
yield
assert_bash_exec(bash, f"unset -f {request.param}")

def test_1_trailing_colons(self, bash, functions, remove_one_tool):
output = assert_bash_exec(
bash,
"_comp__test_compgen available_interfaces",
want_output=True,
)
assert ":>" not in output.strip()

def test_2_correct_interfaces(self, bash, functions, remove_one_tool):
with bash_env_saved(bash) as bash_env:
# Using emulated ip and ifconfig commands
bash_env.write_variable(
"PATH", "$PWD/shared/bin:$PATH", quote=False
)
output = assert_bash_exec(
bash,
"_comp__test_compgen available_interfaces",
want_output=True,
)
assert all(
iface in output
for iface in ["<eth0>", "<lo>", "<peer1>", "<peer2>"]
)
Loading