Remove usage .version and replace it with $dir variable. #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable has format like: 1.24, 2.4-micro, 13. So it can be used for tagging and testing. As well as for test.sh it can be used Signed-off-by: Petr "Stone" Hracek <[email protected]>
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
|
[test] |
Testing Farm results
|
frenzymadness
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
The changes look good to me, and the tests in sclorg/s2i-python-container#755 proved that they work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage .version and replace it with $dir variable.
The variable has format like:
1.24, 2.4-micro, 13.
So it can be used for tagging and testing.
As well as for test.sh it can be used