-
Notifications
You must be signed in to change notification settings - Fork 42
Build regression #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build regression #407
Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
9c9056f
to
369b6ac
Compare
[test] |
Testing Farm results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nitpicks from me.
We need to analyse logs by LogDetective Signed-off-by: Petr "Stone" Hracek <[email protected]>
Do not duplicate code. This also fixes issue #405 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
This function calls test suite specified by first parameter and in case of failure it sends the failed logs to logdetective Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
369b6ac
to
b50b669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like when PRs make the codebase smaller.
This pull request fixes regression during the build of container in case several versions are build.
We should not stop the other builds, but rather continue.
Also
analyze_logs_by_logdetective
are moved to common.sh function