Skip to content

Conversation

phracek
Copy link
Member

@phracek phracek commented Sep 24, 2025

This pull request fixes regression during the build of container in case several versions are build.

We should not stop the other builds, but rather continue.

Also analyze_logs_by_logdetective are moved to common.sh function

Copy link

github-actions bot commented Sep 24, 2025

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

@phracek
Copy link
Member Author

phracek commented Sep 30, 2025

[test]

Copy link

github-actions bot commented Sep 30, 2025

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - nginx-containerFedora-latestx86_64✅ passed30.09.2025 12:18:4512min 16stest pipeline
CentOS Stream 10 - postgresql-containerCentOS-Stream-10x86_64✅ passed30.09.2025 12:18:4415min 36stest pipeline
CentOS Stream 10 - nginx-containerCentOS-Stream-10x86_64✅ passed30.09.2025 12:18:4614min 7stest pipeline
CentOS Stream 9 - nginx-containerCentOS-Stream-9x86_64✅ passed30.09.2025 12:18:4316min 60stest pipeline
RHEL10 - nginx-containerRHEL-10-Nightlyx86_64✅ passed30.09.2025 12:18:4818min 21stest pipeline
Fedora - postgresql-containerFedora-latestx86_64✅ passed30.09.2025 12:18:4619min 13stest pipeline
RHEL10 - postgresql-containerRHEL-10-Nightlyx86_64✅ passed30.09.2025 12:18:4320min 21stest pipeline
RHEL9 - s2i-base-containerRHEL-9.6.0-Nightlyx86_64✅ passed30.09.2025 12:18:4423min 21stest pipeline
CentOS Stream 9 - s2i-perl-containerCentOS-Stream-9x86_64✅ passed30.09.2025 12:20:3323min 59stest pipeline
RHEL8 - nginx-containerRHEL-8.10.0-Nightlyx86_64✅ passed30.09.2025 12:18:4524min 31stest pipeline
CentOS Stream 9 - postgresql-containerCentOS-Stream-9x86_64✅ passed30.09.2025 12:18:4624min 50stest pipeline
RHEL10 - s2i-perl-containerRHEL-10-Nightlyx86_64✅ passed30.09.2025 12:18:4427min 38stest pipeline
RHEL9 - nginx-containerRHEL-9.6.0-Nightlyx86_64✅ passed30.09.2025 12:18:4329min 12stest pipeline
RHEL9 - s2i-perl-containerRHEL-9.6.0-Nightlyx86_64✅ passed30.09.2025 12:18:4730min 13stest pipeline
CentOS Stream 10 - s2i-base-containerCentOS-Stream-10x86_64✅ passed30.09.2025 12:35:0116min 14stest pipeline
RHEL9 - postgresql-containerRHEL-9.6.0-Nightlyx86_64✅ passed30.09.2025 12:18:4534min 54stest pipeline
Fedora - s2i-perl-containerFedora-latestx86_64✅ passed30.09.2025 12:18:4639min 50stest pipeline
RHEL8 - postgresql-containerRHEL-8.10.0-Nightlyx86_64✅ passed30.09.2025 12:18:4442min 49stest pipeline
CentOS Stream 10 - s2i-perl-containerCentOS-Stream-10x86_64✅ passed30.09.2025 12:41:0521min 43stest pipeline
RHEL10 - s2i-base-containerRHEL-10-Nightlyx86_64✅ passed30.09.2025 12:45:0917min 48stest pipeline
RHEL8 - s2i-base-containerRHEL-8.10.0-Nightlyx86_64✅ passed30.09.2025 12:39:1122min 42stest pipeline
RHEL10 - s2i-python-containerRHEL-10-Nightlyx86_64✅ passed30.09.2025 12:35:1028min 58stest pipeline
CentOS Stream 10 - s2i-python-containerCentOS-Stream-10x86_64✅ passed30.09.2025 12:35:2436min 24stest pipeline
Fedora - s2i-python-containerFedora-latestx86_64✅ passed30.09.2025 12:33:0341min 40stest pipeline
Fedora - s2i-base-containerFedora-latestx86_64✅ passed30.09.2025 12:40:0343min 17stest pipeline
CentOS Stream 9 - s2i-python-containerCentOS-Stream-9x86_64✅ passed30.09.2025 12:18:441h 23min 51stest pipeline
RHEL9 - s2i-python-containerRHEL-9.6.0-Nightlyx86_64✅ passed30.09.2025 12:45:061h 16min 15stest pipeline
RHEL8 - s2i-python-containerRHEL-8.10.0-Nightlyx86_64✅ passed30.09.2025 12:37:012h 24stest pipeline

Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nitpicks from me.

We need to analyse logs by LogDetective

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Do not duplicate code.

This also fixes issue #405

Signed-off-by: Petr "Stone" Hracek <[email protected]>
This function calls test suite specified by first parameter
and in case of failure it sends the failed logs to logdetective

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek force-pushed the fix_building_regression branch from 369b6ac to b50b669 Compare October 8, 2025 12:32
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like when PRs make the codebase smaller.

@phracek phracek merged commit ea965c6 into master Oct 9, 2025
3 checks passed
@phracek phracek deleted the fix_building_regression branch October 9, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants